Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve Makefile #986

Merged
merged 1 commit into from
Nov 9, 2022
Merged

chore: improve Makefile #986

merged 1 commit into from
Nov 9, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Nov 9, 2022

  • Reorder commands into groups:
    1. Install
    2. Build
    3. Protobuf
    4. Docker
    5. Lint
    6. Test
  • Add .PHONY targets to commands that don't generate files
  • Add echo statements to describe what command is doing

@rootulp
chore: improve Makefile
3c501c0 
- Reorder commands into groups:
  1. Install
  2. Build
  3. Protobuf
  4. Docker
  5. Lint
  6. Test
- Add `.PHONY` targets to commands that don't generate files
- Add `echo` statements to describe what command is doing
@rootulp rootulp requested a review from rach-id November 9, 2022 16:17
@rootulp rootulp self-assigned this Nov 9, 2022
evan-forbes
evan-forbes approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@rootulp rootulp merged commit 3bc6aae into celestiaorg:main Nov 9, 2022
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
@rootulp @rach-id
chore: improve Makefile (celestiaorg#986)
c575ef8 
- Reorder commands into groups:
  1. Install
  2. Build
  3. Protobuf
  4. Docker
  5. Lint
  6. Test
- Add `.PHONY` targets to commands that don't generate files
- Add `echo` statements to describe what command is doing
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
@rootulp @rach-id
chore: improve Makefile (celestiaorg#986)
5d61546 
- Reorder commands into groups:
  1. Install
  2. Build
  3. Protobuf
  4. Docker
  5. Lint
  6. Test
- Add `.PHONY` targets to commands that don't generate files
- Add `echo` statements to describe what command is doing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@rach-id rach-id Awaiting requested review from rach-id

Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rootulp @evan-forbes