Update Docker image build pipelines #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main-docker-build does arm and amd
evan-forbes
approved these changes
Nov 10, 2022
rootulp
approved these changes
Nov 10, 2022
rach-id
approved these changes
Nov 10, 2022
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
# PULL REQUEST <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Updates the Docker image build Github Action Pipelines. The `amd64-docker-build` job is run on all pushes to all branches. It creates a `linux/amd64` docker image that is tagged with the short commit sha. [Example Job](https://github.com/jbowen93/celestia-app/actions/runs/3432472621/jobs/5721783469) w/ [resulting image](https://github.com/jbowen93/celestia-app/pkgs/container/celestia-app/49690412?tag=sha-9087311) The `main-docker-build` job runs on pushes to `main` as well as when any new tags are pushed. It creates both a `linux/arm64` image and a `linux/amd64` image. When run against `main` the image is tagged with the short commit sha. When run against a tag the image is tagged with the git tag. [Example Job](https://github.com/jbowen93/celestia-app/actions/runs/3432479009/jobs/5721797340) w/ [resulting image](https://github.com/jbowen93/celestia-app/pkgs/container/celestia-app/49692397?tag=sha-ff1c238) [Example Job](https://github.com/jbowen93/celestia-app/actions/runs/3432357771) for a tagged run w/ [resulting image](https://github.com/jbowen93/celestia-app/pkgs/container/celestia-app/49690070?tag=0.0.91-rc1). ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
# PULL REQUEST <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Updates the Docker image build Github Action Pipelines. The `amd64-docker-build` job is run on all pushes to all branches. It creates a `linux/amd64` docker image that is tagged with the short commit sha. [Example Job](https://github.com/jbowen93/celestia-app/actions/runs/3432472621/jobs/5721783469) w/ [resulting image](https://github.com/jbowen93/celestia-app/pkgs/container/celestia-app/49690412?tag=sha-9087311) The `main-docker-build` job runs on pushes to `main` as well as when any new tags are pushed. It creates both a `linux/arm64` image and a `linux/amd64` image. When run against `main` the image is tagged with the short commit sha. When run against a tag the image is tagged with the git tag. [Example Job](https://github.com/jbowen93/celestia-app/actions/runs/3432479009/jobs/5721797340) w/ [resulting image](https://github.com/jbowen93/celestia-app/pkgs/container/celestia-app/49692397?tag=sha-ff1c238) [Example Job](https://github.com/jbowen93/celestia-app/actions/runs/3432357771) for a tagged run w/ [resulting image](https://github.com/jbowen93/celestia-app/pkgs/container/celestia-app/49690070?tag=0.0.91-rc1). ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
May 25, 2023
# PULL REQUEST <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Updates the Docker image build Github Action Pipelines. The `amd64-docker-build` job is run on all pushes to all branches. It creates a `linux/amd64` docker image that is tagged with the short commit sha. [Example Job](https://github.com/jbowen93/celestia-app/actions/runs/3432472621/jobs/5721783469) w/ [resulting image](https://github.com/jbowen93/celestia-app/pkgs/container/celestia-app/49690412?tag=sha-9087311) The `main-docker-build` job runs on pushes to `main` as well as when any new tags are pushed. It creates both a `linux/arm64` image and a `linux/amd64` image. When run against `main` the image is tagged with the short commit sha. When run against a tag the image is tagged with the git tag. [Example Job](https://github.com/jbowen93/celestia-app/actions/runs/3432479009/jobs/5721797340) w/ [resulting image](https://github.com/jbowen93/celestia-app/pkgs/container/celestia-app/49692397?tag=sha-ff1c238) [Example Job](https://github.com/jbowen93/celestia-app/actions/runs/3432357771) for a tagged run w/ [resulting image](https://github.com/jbowen93/celestia-app/pkgs/container/celestia-app/49690070?tag=0.0.91-rc1). ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords (cherry picked from commit 7971341)
evan-forbes
pushed a commit
that referenced
this pull request
May 26, 2023
# PULL REQUEST <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Updates the Docker image build Github Action Pipelines. The `amd64-docker-build` job is run on all pushes to all branches. It creates a `linux/amd64` docker image that is tagged with the short commit sha. [Example Job](https://github.com/jbowen93/celestia-app/actions/runs/3432472621/jobs/5721783469) w/ [resulting image](https://github.com/jbowen93/celestia-app/pkgs/container/celestia-app/49690412?tag=sha-9087311) The `main-docker-build` job runs on pushes to `main` as well as when any new tags are pushed. It creates both a `linux/arm64` image and a `linux/amd64` image. When run against `main` the image is tagged with the short commit sha. When run against a tag the image is tagged with the git tag. [Example Job](https://github.com/jbowen93/celestia-app/actions/runs/3432479009/jobs/5721797340) w/ [resulting image](https://github.com/jbowen93/celestia-app/pkgs/container/celestia-app/49692397?tag=sha-ff1c238) [Example Job](https://github.com/jbowen93/celestia-app/actions/runs/3432357771) for a tagged run w/ [resulting image](https://github.com/jbowen93/celestia-app/pkgs/container/celestia-app/49690070?tag=0.0.91-rc1). ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords (cherry picked from commit 7971341)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
Updates the Docker image build Github Action Pipelines.
The
amd64-docker-buildjob is run on all pushes to all branches. It creates alinux/amd64docker image that is tagged with the short commit sha.Example Job w/ resulting image
The
main-docker-buildjob runs on pushes tomainas well as when any new tags are pushed. It creates both alinux/arm64image and alinux/amd64image. When run againstmainthe image is tagged with the short commit sha. When run against a tag the image is tagged with the git tag.Example Job w/ resulting image
Example Job for a tagged run w/ resulting image.
Checklist