Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test for gas usage #998

Merged
merged 1 commit into from
Nov 11, 2022
Merged

chore: test for gas usage #998

merged 1 commit into from
Nov 11, 2022

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Nov 11, 2022

Overview

adds a check for gas usage during the integration test

closes #389

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@evan-forbes evan-forbes added the testing items that are strictly related to adding or extending test coverage label Nov 11, 2022
@evan-forbes evan-forbes self-assigned this Nov 11, 2022
@evan-forbes evan-forbes enabled auto-merge (squash) November 11, 2022 03:02
@codecov-commenter
Copy link

Codecov Report

Merging #998 (0eeaf06) into main (37dbad1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
+ Coverage   27.49%   27.52%   +0.02%     
==========================================
  Files          81       81              
  Lines        9099     9102       +3     
==========================================
+ Hits         2502     2505       +3     
  Misses       6359     6359              
  Partials      238      238              
Impacted Files Coverage Δ
testutil/testnode/node_interaction_api.go 62.83% <100.00%> (+1.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@evan-forbes evan-forbes merged commit 18c9cab into main Nov 11, 2022
@evan-forbes evan-forbes deleted the evan/test-for-gas-usage branch November 11, 2022 03:07
@rootulp
Copy link
Collaborator

rootulp commented Nov 11, 2022

wow this merged before the last CI test passed 🤔

rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
## Overview

adds a check for gas usage during the integration test

closes celestiaorg#389 

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
## Overview

adds a check for gas usage during the integration test

closes celestiaorg#389 

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure fees were deducted when submitting a PayForData in the cli integration test
3 participants