fix: pass version when converting between proto consensus params types #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninabarbakadze
approved these changes
Jan 31, 2024
staheri14
approved these changes
Jan 31, 2024
rootulp
approved these changes
Jan 31, 2024
| @@ -105,6 +105,7 @@ func (tm2pb) ConsensusParams(params *cmtproto.ConsensusParams) *abci.ConsensusPa | |||
| }, | |||
| Evidence: ¶ms.Evidence, | |||
| Validator: ¶ms.Validator, | |||
| Version: ¶ms.Version, | |||
There was a problem hiding this comment.
I have a few non-blocking questions.
- Is this function a translation layer from CometBFT protobuf types to ABCI protobuf types? Silly question but why does it need to exist? The types seem almost interchangeable.
- Was this broken upstream or a Celestia specific modification in celestia-core caused this issue? It looks like upstream is broken too: https://github.com/cometbft/cometbft/blob/e0e50aa9fca730ec208b67b54e48c8bdc630c17b/types/protobuf.go#L100-L109
- Should we add a unit test in protobuf_test.go to prevent regressions?
There was a problem hiding this comment.
this isn't broken on main, where we just use the toProto method. here I wanted to minimize the number the changes, but the best approach would be to do what main does, which is to delete these and only use the ToProto methods and have round trip unit tests
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1201 this issue only affects v0.34.x