Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS #213

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Update CODEOWNERS #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@
# global owners are only requested if there isn't a more specific
# codeowner specified below. For this reason, the global codeowners
# are often repeated in package-level definitions.
* @marbar3778 @liamsi @musalbas
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this @musalbas won't be added as a reviewer per default.

* @marbar3778 @liamsi @evan-forbes

# Overrides for tooling packages
.circleci/ @marbar3778 @liamsi
.github/ @marbar3778 @liamsi
DOCKER/ @marbar3778 @liamsi
docs/ @marbar3778 @liamsi @adlerjohn @musalbas
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it still makes sense for @musalbas and @adlerjohn to be added as reviewers on docs. Especially on ADRs.