New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: blocking peer over RPC does not block us from handling their EDS requests #2146

Open

Tracked by

distractedm1nd opened this issue Apr 28, 2023 · 1 comment

Assignees

Labels

area:shares bug

Member

distractedm1nd commented Apr 28, 2023

I believe the stream shouldnt even be opened when we block a peer, but this isn't happening for shrexeds server when we block a peer

distractedm1nd added bug area:shares labels

distractedm1nd self-assigned this

renaynay mentioned this issue

[EPIC] shrex stability + performance #2106

Open

Member

renaynay commented May 10, 2023

// BlockPeer adds a peer to the set of blocked peers.
// Note: active connections to the peer are not automatically closed.
func (cg *BasicConnectionGater) BlockPeer(p peer.ID) error {

@distractedm1nd - there would need to be a manual disconnect as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment