Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodebuilder/tests: Investigate why event connectedness subscription isn't working in TestFullDiscoveryViaBootstrapper #2649

Open
renaynay opened this issue Sep 4, 2023 · 3 comments
Labels
area:p2p kind:testing Related to unit tests swamp Related to Integration tests

Comments

@renaynay
Copy link
Member

renaynay commented Sep 4, 2023

          Investigate why subscription isn't working in this test.

Originally posted by @renaynay in #2166 (comment)

@nodersteam
Copy link
Contributor

@renaynay

Could you describe in a little more detail what exactly needs to be fixed?

I see that the tests are passing, and we don’t fully understand what exactly needs to be completed

@nodersteam
Copy link
Contributor

Like this?
image

@walldiss
Copy link
Member

Hi @nodersteam. It is minor issue with the test being inefficient on cpu. At some point tests wants to wait for connection to be succeeded. Currently it checks it in endless poll loop. There is an api in libp2p to subscribe to connectivity event, that should allow to catch such event once it happens. So it needs to be investigated how to setup subscription to catch connectivity event at given test stage reliably.

@ramin ramin added the kind:testing Related to unit tests label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:p2p kind:testing Related to unit tests swamp Related to Integration tests
Projects
None yet
Development

No branches or pull requests

4 participants