Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

state: SubmitPayForBlob API update #10

Closed
tuxcanfly opened this issue Jun 14, 2023 · 1 comment · Fixed by #11
Closed

state: SubmitPayForBlob API update #10

tuxcanfly opened this issue Jun 14, 2023 · 1 comment · Fixed by #11

Comments

@tuxcanfly
Copy link
Contributor

tuxcanfly commented Jun 14, 2023 •
edited
Loading

The API for SubmitPayForBlob has been updated:

celestiaorg/celestia-node@2496013#diff-96a4e91e4092e681968a66faad463df134d7959e22d1258fc2459a84b0802e4c

the new API is:

	SubmitPayForBlob(
		ctx context.Context,
		fee state.Int,
		gasLim uint64,
		blobs ...*apptypes.Blob,

This needs to reflect in StateAPI.SubmitPayForBlob.
@tuxcanfly tuxcanfly mentioned this issue Jun 14, 2023
Merged
5 tasks
@tuxcanfly
Copy link
Contributor Author

The new API depends on celestia-core/proto/tendermint/types.Blob.

Needs to be added to rollkit cometbft fork.

@tuxcanfly tuxcanfly mentioned this issue Jun 14, 2023
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 5, 2023
@tuxcanfly
state: update SubmitPayForBlob api; api: add BlobAPI (#11)
f89b1d9 
## Overview

This PR adds `type Blob`, adds `BlobAPI` and updates the API for
`SubmitPayForBlob` to the latest version of celestia-node.

Fixes #10 

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

state: update SubmitPayForBlob api; api: add BlobAPI celestiaorg/celestia-openrpc
1 participant
@tuxcanfly