Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add misc setup docs and workflows #5

Merged
merged 4 commits into from
Jun 26, 2023
Merged

add misc setup docs and workflows #5

merged 4 commits into from
Jun 26, 2023

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented May 18, 2023

copied over various common workflows and initialization files from rollkit.

with the new auto request workflow, we shouldn't need a CODEOWNERS file as that is covered in the auto request workflow. The auto request won't run until this PR is merged.

@MSevey MSevey requested review from tzdybal and nashqueue May 18, 2023 15:11
@MSevey MSevey self-assigned this May 18, 2023
@MSevey
Copy link
Member Author

MSevey commented May 18, 2023

NOTE: i expect most of the workflows to fail right now until the initial code is pushed as which point we can start fixing the workflows.

Copy link
Member

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY :) small nits on proto generation

.github/workflows/proto.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@MSevey
Copy link
Member Author

MSevey commented May 19, 2023

TY :) small nits on proto generation

removed all protobuf code 👍

nashqueue
nashqueue previously approved these changes May 31, 2023
@nashqueue
Copy link
Member

We are checking lints against Go version 1.20, which might have a conflict with rollkit.

Copy link
Member

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rebasing this should be ready for merging.

NOTICE Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
This was referenced Jun 5, 2023
@tzdybal tzdybal enabled auto-merge June 15, 2023 20:59
Copy link
Member

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzdybal tzdybal merged commit ae6f9e4 into main Jun 26, 2023
6 of 9 checks passed
@tzdybal tzdybal deleted the sevey/setup-docs branch June 26, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants