Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: Bumps celestia-node compatibility to v0.11.0 #64

Merged
merged 1 commit into from
Oct 17, 2023
Merged

chore!: Bumps celestia-node compatibility to v0.11.0 #64

merged 1 commit into from
Oct 17, 2023

Conversation

renaynay
Copy link
Member

Getter interface from celestia-node broke thanks to go-header

GetVerifiedRange is now called GetRangeByHeight

Please keep in mind that this is the method signature:

// GetRangeByHeight returns (fromHead.Height(): to) 
GetRangeByHeight func(ctx context.Context, fromHead *header.ExtendedHeader, to uint64) ([]*header.ExtendedHeader, error) `perm:"read"`

@gupadhyaya gupadhyaya added the bug Something isn't working label Oct 17, 2023
@renaynay
Copy link
Member Author

It was complaining about needing to tidy go.mod @gupadhyaya

nashqueue
nashqueue approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you utAck

@gupadhyaya gupadhyaya added this pull request to the merge queue Oct 17, 2023
Merged via the queue into celestiaorg:main with commit 4ad7745 Oct 17, 2023
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gupadhyaya gupadhyaya gupadhyaya approved these changes

@nashqueue nashqueue nashqueue approved these changes

@Manav-Aggarwal Manav-Aggarwal Awaiting requested review from Manav-Aggarwal

Assignees

@renaynay renaynay

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@renaynay @gupadhyaya @nashqueue