Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose SetTxDecoder #311

Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Apr 26, 2023

@rootulp rootulp self-assigned this Apr 26, 2023
@rootulp rootulp requested review from cmwaters and removed request for liamsi April 26, 2023 20:51
@evan-forbes
Copy link
Member

for posterity, the other option to this is pulling out the tx config in the auth module, but that requires exporting some of the sign mode handlers and the wrapper struct that is used for tx building. If we do that, then we will likely need or want to pull out the entire auth module.

This seems like the simplest solution to celestiaorg/celestia-app#1665

@rootulp rootulp merged commit c4aea6f into celestiaorg:release/v0.46.x-celestia Apr 27, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants