feat: allow for the default consensus params to be set by the application #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
approved these changes
May 11, 2023
Closed
5 tasks
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Codecov Report
@@ Coverage Diff @@
## release/v0.46.x-celestia #317 +/- ##
=========================================================
Coverage 65.54% 65.55%
=========================================================
Files 666 666
Lines 70983 70986 +3
=========================================================
+ Hits 46529 46532 +3
Misses 21876 21876
Partials 2578 2578
|
cmwaters
approved these changes
May 12, 2023
evan-forbes
added a commit
that referenced
this pull request
Sep 4, 2023
…tion (#317) * feat: allow for the default consensus params to be set by the application * chore: add test * fix: spelling Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> --------- Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the consensus params to the server context, so that the init cli command can add it to the genesis document. This allows for the consensus parameters to be set by the application.