celestia-node v0.14.0: RPC port no longer necessary for nodes to query state #1558
Conversation
…l nodes to query state
WalkthroughThe update aims to standardize and simplify network communication protocols in the Celestia network by transitioning to a single gRPC endpoint for consensus and data availability functionalities, improving configuration clarity and efficiency. Changes
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (4)
Additional Context UsedLanguageTool (157)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
thank you for this PR as well @renaynay. It looks like you found the 2 occurrences of this in docs. Can you confirm that a bridge node can be started with |
This will change once this lands and node adopts it: celestiaorg/celestia-app#3421 |
|
note to self to add
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Out of diff range and nitpick comments (1)
nodes/mocha-testnet.md (1)
Line range hint
94-95: Replace the en dash–with a hyphen-in–core.ip stringto avoid potential issues in command execution.- –core.ip string + --core.ip string
|
|
||
| :::tip | ||
|
|
||
| ```bash | ||
| celestia <da_type> start --core.ip <url> –core.rpc.port <port> \ | ||
| –core.grpc.port <port> | ||
| celestia <da_type> start --core.ip <url> -–core.grpc.port <port> |
There was a problem hiding this comment.
Correct the command syntax error.
- celestia <da_type> start --core.ip <url> -–core.grpc.port <port>
+ celestia <da_type> start --core.ip <url> --core.grpc.port <port>Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| celestia <da_type> start --core.ip <url> -–core.grpc.port <port> | |
| celestia <da_type> start --core.ip <url> --core.grpc.port <port> |
| For users, they will need to provide a `–core.ip string` | ||
| from a consensus node’s URL or IP that populates a default RPC port at 26657 | ||
| to their respective DA node. |
There was a problem hiding this comment.
Replace the en dash – with a hyphen - in –core.ip string to avoid potential issues in command execution.
- –core.ip string
+ --core.ip stringCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| For users, they will need to provide a `–core.ip string` | |
| from a consensus node’s URL or IP that populates a default RPC port at 26657 | |
| to their respective DA node. | |
| For users, they will need to provide a `--core.ip string` | |
| from a consensus node’s URL or IP that populates a default RPC port at 26657 | |
| to their respective DA node. |
| @@ -79,7 +79,7 @@ Ubuntu. You can | |||
|
|
|||
| ::: | |||
|
|
|||
| 3. Set an RPC endpoint for either [Mainnet Beta](./mainnet.md#da-rpc-endpoints), | |||
| 3. Set an RPC endpoint for either [Mainnet Beta](./mainnet.md#data-availability-da-grpc-endpoints-for-state-access), | |||
There was a problem hiding this comment.
Replace the en dash – with a hyphen - in –core.ip string to avoid potential issues in command execution.
- –core.ip string
+ --core.ip stringCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| 3. Set an RPC endpoint for either [Mainnet Beta](./mainnet.md#data-availability-da-grpc-endpoints-for-state-access), | |
| 3. Set an RPC endpoint for either [Mainnet Beta](./mainnet.md#data-availability-da-grpc-endpoints-for-state-access), |
| For users, they will need to provide a `–core.ip string` | ||
| from a consensus node’s URL or IP that populates a default RPC port at 26657 |
There was a problem hiding this comment.
Replace the en dash – with a hyphen - in –core.ip string to avoid potential issues in command execution.
- –core.ip string
+ --core.ip stringCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| For users, they will need to provide a `–core.ip string` | |
| from a consensus node’s URL or IP that populates a default RPC port at 26657 | |
| For users, they will need to provide a `--core.ip string` | |
| from a consensus node’s URL or IP that populates a default RPC port at 26657 |
| Celestia network. For users, they will need to provide a `–core.ip string` | ||
| from a consensus node’s URL or IP that populates a default gRPC port at 9090 |
There was a problem hiding this comment.
Replace the en dash – with a hyphen - in –core.ip string to avoid potential issues in command execution.
- –core.ip string
+ --core.ip stringCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| Celestia network. For users, they will need to provide a `–core.ip string` | |
| from a consensus node’s URL or IP that populates a default gRPC port at 9090 | |
| Celestia network. For users, they will need to provide a `--core.ip string` | |
| from a consensus node’s URL or IP that populates a default gRPC port at 9090 |
…for state reads (#3359) Resolves #3357 Blocked on patch release from app including celestiaorg/celestia-app#3424 Corresponding docs PR celestiaorg/docs#1558
I tried to add all information I could here, but @jcstein maybe you can also help to make sure I've addressed all areas where rpc port is mentioned for state queries for DA nodes
What's important to note is that
LNs and FNs no longer need a
--core.rpc.portperiod but BNs still need it for block syncing.This feature will only be included in v0.14.0 of celestia-node!
Summary by CodeRabbit