Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(p2p/exchange): Remove peer blocking from head request #113

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Oct 4, 2023

Currently, the exchange will block peers for giving a bad header that does not pass the Verify check (unless it is a SoftFailure). Unless we introduce another field inside of VerifyError to indicate to the caller whether the error was severe enough to warrant blocking, we shouldn't blanket block for verify errors as a good peer that sends a slightly outdated header will get banned.

(this is currently observable on arabica - have not tested on mocha yet)

Moral of the story: do not prematurely implement blocking behaviour.

@codecov-commenter
Copy link

Codecov Report

Merging #113 (a2895a7) into main (e75d00d) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   69.20%   69.16%   -0.05%     
==========================================
  Files          37       37              
  Lines        2939     2938       -1     
==========================================
- Hits         2034     2032       -2     
  Misses        756      756              
- Partials      149      150       +1     
Files Coverage Δ
p2p/exchange.go 85.89% <ø> (-0.07%) ⬇️

... and 2 files with indirect coverage changes

@renaynay renaynay merged commit e7d24b8 into celestiaorg:main Oct 5, 2023
3 checks passed
@renaynay renaynay deleted the remove-block branch October 5, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants