feat(syncer/metrics): add metrics to syncer #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
force-pushed
the
metrics_for_syncer
branch
2 times, most recently
from
0b7da9e
to
bd7bb1f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 63.60% 63.03% -0.58%
==========================================
Files 39 39
Lines 3366 3476 +110
==========================================
+ Hits 2141 2191 +50
- Misses 1060 1113 +53
- Partials 165 172 +7 ☔ View full report in Codecov by Sentry. |
walldiss
reviewed
Dec 13, 2023
|
Please note, that peer info is not shown on the second screenshot because only one node was running |
vgonkivs
requested review from
tzdybal,
renaynay,
Wondertan and
gupadhyaya
as code owners
ramin
reviewed
Dec 15, 2023
walldiss
reviewed
Dec 15, 2023
vgonkivs
force-pushed
the
metrics_for_syncer
branch
from
81d3d2b
to
f4bd812
Compare
Wondertan
requested changes
Dec 15, 2023
vgonkivs
force-pushed
the
metrics_for_syncer
branch
from
9759445
to
04cd1d6
Compare
renaynay
previously requested changes
Jan 8, 2024
walldiss
reviewed
Jan 9, 2024
renaynay
reviewed
Jan 10, 2024
renaynay
reviewed
Jan 10, 2024
Wondertan
requested changes
Jan 25, 2024
|
@vgonkivs, this is a feature, not misc |
Wondertan
requested changes
Jan 30, 2024
Wondertan
changed the title
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
vgonkivs
force-pushed
the
metrics_for_syncer
branch
from
adb71cd
to
b3f5719
Compare
walldiss
approved these changes
Feb 1, 2024
Wondertan
approved these changes
Feb 1, 2024
vgonkivs
dismissed
renaynay’s stale review
need to ship in order to start testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add metrics to syncer
Checklist