Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(p2p): cover Exchange with traces #150

Merged
merged 11 commits into from
Feb 1, 2024

Conversation

vgonkivs
Copy link
Member

Overview

Add traces for p2p.session

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (446648d) 63.96% compared to head (cd263e1) 62.95%.
Report is 3 commits behind head on main.

Files Patch % Lines
p2p/exchange.go 81.63% 9 Missing ⚠️
p2p/session.go 90.32% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   63.96%   62.95%   -1.02%     
==========================================
  Files          39       39              
  Lines        3383     3593     +210     
==========================================
+ Hits         2164     2262      +98     
- Misses       1052     1157     +105     
- Partials      167      174       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Wondertan
Wondertan previously approved these changes Jan 30, 2024
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be also nice to cover Head.

p2p/exchange.go Outdated Show resolved Hide resolved
p2p/exchange.go Outdated Show resolved Hide resolved
p2p/exchange.go Show resolved Hide resolved
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general comment, there seems to be duplication of traces in paths where metrics are already covering. Let's reduce the amount of traces to events that are of interest -- the hottest of hottest paths (specifically Head request and get range by height, etc.) and only tracing the absolute most interesting events.

p2p/exchange.go Show resolved Hide resolved
p2p/exchange.go Outdated Show resolved Hide resolved
p2p/exchange.go Outdated Show resolved Hide resolved
p2p/exchange.go Outdated Show resolved Hide resolved
p2p/exchange.go Outdated Show resolved Hide resolved
p2p/exchange.go Outdated Show resolved Hide resolved
p2p/exchange.go Outdated Show resolved Hide resolved
p2p/exchange.go Outdated Show resolved Hide resolved
p2p/exchange.go Outdated Show resolved Hide resolved
@vgonkivs
Copy link
Member Author

vgonkivs commented Feb 1, 2024

I don't get why this is needed here even on old version tbh

context is needed to create the baggage. And we will get a race if do not copy the variable.

renaynay
renaynay previously approved these changes Feb 1, 2024
p2p/exchange.go Show resolved Hide resolved
p2p/session.go Outdated Show resolved Hide resolved
p2p/exchange.go Outdated Show resolved Hide resolved
p2p/session.go Outdated Show resolved Hide resolved
p2p/exchange.go Outdated Show resolved Hide resolved
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

p2p/exchange.go Show resolved Hide resolved
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utack

@Wondertan Wondertan changed the title feat(traces/session): cover session with traces feat(p2p): cover session with traces Feb 1, 2024
@Wondertan Wondertan changed the title feat(p2p): cover session with traces feat(p2p): cover Exchange session with traces Feb 1, 2024
@Wondertan Wondertan changed the title feat(p2p): cover Exchange session with traces feat(p2p): cover Exchange with traces Feb 1, 2024
@Wondertan Wondertan enabled auto-merge (squash) February 1, 2024 19:09
@Wondertan Wondertan merged commit aecd7cf into celestiaorg:main Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants