fix(store): add error details to log output during header batch write #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log output has been updated for a better troubleshooting experience when writing a batch of headers. Previously, when an error occurred, the log provided 'from' and 'to' ranges without specifying the actual error. Now, the 'err' parameter has been added to provide more information about the exact issue.
tzdybal
requested review from
renaynay,
Wondertan,
vgonkivs and
gupadhyaya
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
- Coverage 63.01% 62.95% -0.06%
==========================================
Files 39 39
Lines 3593 3593
==========================================
- Hits 2264 2262 -2
- Misses 1155 1157 +2
Partials 174 174 ☔ View full report in Codecov by Sentry. |
renaynay
approved these changes
Mar 7, 2024
Wondertan
approved these changes
Mar 7, 2024
vgonkivs
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The log output has been updated for a better troubleshooting experience when writing a batch of headers. Previously, when an error occurred, the log provided 'from' and 'to' ranges without specifying the actual error. Now, the 'err' parameter has been added to provide more information about the exact issue.
Checklist