chore(sync)!: Rename unrecentHead to outdatedHead in metrics + clean up Head func a bit
#163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ean up `Head` func a bit
renaynay
requested review from
tzdybal,
Wondertan,
vgonkivs and
gupadhyaya
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
- Coverage 62.90% 62.85% -0.05%
==========================================
Files 39 39
Lines 3577 3578 +1
==========================================
- Hits 2250 2249 -1
- Misses 1154 1156 +2
Partials 173 173 ☔ View full report in Codecov by Sentry. |
vgonkivs
previously approved these changes
Mar 7, 2024
Wondertan
reviewed
Mar 7, 2024
Wondertan
approved these changes
Mar 11, 2024
vgonkivs
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames a poorly named metric from
unrecent_headertooutdated_headwhich is more descriptive / accurate.It also cleans up a bit of the code inside of
sync_head.go.This PR is meant to override #162 if we agree that the timeout should not be configurable (see comment