fix(store): greedy heightSub cancellation #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So I was playing around with the similar code and taking heightSub as an inspiration. While writing that code I realized that heightSub has a nasty bug. Basically a subscription cancellation removes the others active subs for the same height leaving them blocked forever. We could observe some abnormal blockings in the past and this may explain it.
Wondertan
requested review from
tzdybal,
renaynay,
vgonkivs and
gupadhyaya
as code owners
Wondertan
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 62.88% 63.02% +0.13%
==========================================
Files 39 39
Lines 3573 3581 +8
==========================================
+ Hits 2247 2257 +10
+ Misses 1154 1152 -2
Partials 172 172 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I was playing around with similar code and taking heightSub as an inspiration. While writing that code, I realized that
heightSubhas a nasty bug. Basically, a subscription cancellation removes the other active subs for the same height, leaving them blocked forever. We could observe some abnormal blockings in the past, which may explain it.I provided a test scenario that proves the issue existed and the fix works.