Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(sync): drop storeHeaders helper #193

Merged
merged 1 commit into from
Jun 3, 2024
Merged

refactor(sync): drop storeHeaders helper #193

merged 1 commit into from
Jun 3, 2024

Conversation

cristaloleg
Copy link
Contributor

Overview

Make store field usage explicit. Plus storeHeaders was just a wrapper around store.Append without any logic.

renaynay
renaynay approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you

@cristaloleg cristaloleg merged commit 4c7a15c into main Jun 3, 2024
4 checks passed
@cristaloleg cristaloleg deleted the sync/drop-storeHeaders-helper branch June 3, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay renaynay approved these changes

@tzdybal tzdybal Awaiting requested review from tzdybal tzdybal is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya gupadhyaya is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

@ramin ramin Awaiting requested review from ramin ramin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cristaloleg @Wondertan @renaynay