refactor: remove redundant error channel on msg sent API #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Messenger returned internal ctx error on closage, which can potentially confuse user as it can be mistaken that the error is coming not from the internal ctx but from the one that is passed by user. Now errors are diffirintiated as new special errClosed type is introduced
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
==========================================
- Coverage 74.32% 72.84% -1.48%
==========================================
Files 9 9
Lines 296 302 +6
==========================================
Hits 220 220
- Misses 56 61 +5
- Partials 20 21 +1
Continue to review full report at Codecov.
|
liamsi
approved these changes
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But also:
Closes #15