Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove empty gentx #365

Closed
wants to merge 1 commit into from
Closed

remove empty gentx #365

wants to merge 1 commit into from

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Oct 21, 2023

Removes the empty file in gentxs. CI currently fails b/c of that: e.g. see: https://github.com/celestiaorg/networks/actions/runs/6597322353/job/17924241218?pr=362

Run if test -f ./celestia/pre-genesis.json; then
Error: EOF: tx parse error
Usage: [...]

@liamsi liamsi marked this pull request as ready for review October 21, 2023 13:27
@MSevey
Copy link
Member

MSevey commented Oct 21, 2023

github will also remove empty directories, so run-network will continue to fail until the first gentx is added.

i think the fix here is to add a readme.md file to the gentx directory. the markdown file shouldn't be read by the genutil tool so it shouldn't impact the CI.

@liamsi
Copy link
Member Author

liamsi commented Oct 21, 2023

github will also remove empty directories, so run-network will continue to fail until the first gentx is added.

But in PRs people create a gentx directory. So CI won't fail for each PR, right? also the gentest tool will fail on a readme.md as well.

@liamsi liamsi requested review from MSevey and removed request for MSevey October 21, 2023 14:18
@liamsi
Copy link
Member Author

liamsi commented Oct 21, 2023

closing in favour of #367

@liamsi liamsi closed this Oct 21, 2023
@liamsi liamsi deleted the remove-emptyjson branch October 21, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants