Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: celestia addrbook.json #514

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Oct 30, 2023

Closes #513

Note: two peers were not added. Created via:

$ celestia-appd addrbook /Users/rootulp/git/rootulp/celestia/networks/celestia/peers.txt /Users/rootulp/git/rootulp/celestia/networks/celestia/addrbook.json
Error adding b751ffe713e3e5d80e8f45c3bd5e640ee9a91cb9@10.129.127.95:26656: Cannot add non-routable address b751ffe713e3e5d80e8f45c3bd5e640ee9a91cb9@10.129.127.95:26656
Error parsing 6c41c4e37467272507e77fd74fd2e9e32e094d84@celestia.xprv.io:30001: error looking up host (celestia.xprv.io): lookup celestia.xprv.io: no such host
Converted /Users/rootulp/git/rootulp/celestia/networks/celestia/peers.txt into /Users/rootulp/git/rootulp/celestia/networks/celestia/addrbook.json

Testing

Created a full consensus node (via mainnet.sh) with this addressbook and didn't encounter any errors but I don't see any logs indicating that it's communicating with the nodes in the addressbook because the genesis time is in the future and it's sleeping...

12:04PM INF Adding unconditional peer ids ids=[] module=p2p
12:04PM INF Add our address to book addr={"id":"f703381387acc941e863252e940d24725521173f","ip":"0.0.0.0","port":26656} book=/Users/rootulp/.celestia-app/config/addrbook.json module=p2p
12:04PM INF service start impl=Node msg={}
12:04PM INF Genesis time is in the future. Sleeping until then... genTime=2023-10-31T14:00:00Z
12:04PM INF Starting pprof server laddr=localhost:6060

@cmwaters
Copy link

I wonder if we want to add a little README.md that explains how to init the node and where to put these two files (genesis and addressbook)

@cmwaters
Copy link

Created a full consensus node (via mainnet.sh) with this addressbook and didn't encounter any errors but I don't see any logs indicating that it's communicating with the nodes in the addressbook because the genesis time is in the future and it's sleeping...

If you want to you could use a different genesis such that we can confirm it's at least trying to dial the peers (even thought it won't be able to connect)

@liamsi liamsi merged commit d8e0363 into celestiaorg:master Oct 30, 2023
7 of 8 checks passed
@rootulp rootulp deleted the rp/celestia-addrbook branch October 30, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate celestia addrbook.json
4 participants