Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: subscription methods #252

Merged
merged 7 commits into from Feb 2, 2022
Merged

RPC: subscription methods #252

merged 7 commits into from Feb 2, 2022

Conversation

tzdybal
Copy link
Member

@tzdybal tzdybal commented Jan 14, 2022 •
edited

RPC: subscription methods

  • Subscribe
  • Unsubscribe
  • UnsubscribeAll

Resolves: #244
Required by: #188

@tzdybal tzdybal added the C:rpc label Jan 14, 2022
@tzdybal tzdybal self-assigned this Jan 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022 •
edited

Codecov Report

Merging #252 (9038f4a) into main (4a03ceb) will increase coverage by 0.41%.
The diff coverage is 70.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   57.29%   57.71%   +0.41%     
==========================================
  Files          42       43       +1     
  Lines        6555     6679     +124     
==========================================
+ Hits         3756     3855      +99     
- Misses       2276     2291      +15     
- Partials      523      533      +10
Impacted Files Coverage Δ
rpc/json/types.go 43.33% <ø> (ø)
rpc/json/ws.go 55.00% <55.00%> (ø)
rpc/json/service.go 63.80% <77.41%> (+11.46%) ⬆️
rpc/json/handler.go 87.97% <94.73%> (+5.30%) ⬆️
rpc/client/client.go 35.10% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a03ceb...9038f4a. Read the comment docs.

@tzdybal tzdybal marked this pull request as ready for review January 24, 2022 16:21
adlerjohn
adlerjohn reviewed Jan 25, 2022
View reviewed changes
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests failing

@tzdybal tzdybal marked this pull request as draft January 25, 2022 21:52
@tzdybal tzdybal marked this pull request as ready for review January 31, 2022 22:02
adlerjohn
adlerjohn approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@tzdybal tzdybal merged commit 39e4050 into main Feb 2, 2022
@tzdybal tzdybal deleted the tzdybal/pubsub_rpc branch February 2, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@liamsi liamsi Awaiting requested review from liamsi

Assignees

@tzdybal tzdybal

Labels
C:rpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Subscribe/Unsubscribe/UnsubscribeAll methods
3 participants
@tzdybal @codecov-commenter @adlerjohn