Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing rebuildShares #199

Closed
rootulp opened this issue Jun 28, 2023 · 2 comments
Closed

Consider removing rebuildShares #199

rootulp opened this issue Jun 28, 2023 · 2 comments
Assignees
@rootulp
Labels
good first issue Good for newcomers

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jun 28, 2023

do we need this function at all if its just decoding?

Originally posted by @evan-forbes in #197 (comment)
@rootulp rootulp added the good first issue Good for newcomers label Jun 28, 2023
@rootulp rootulp mentioned this issue Jun 28, 2023
Merged
@rootulp
Copy link
Collaborator Author

rootulp commented Jun 28, 2023

blocked on #200

@rootulp rootulp mentioned this issue Jun 28, 2023
Closed
@rootulp rootulp self-assigned this Jun 29, 2023
@rootulp
Copy link
Collaborator Author

rootulp commented Jun 30, 2023

Until the error handling logic isn't janky, I think it actually makes sense to retain rebuildShares as a stand-alone function so closing as won't fix.

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: introduce rsmt2d.ErrTooFewShards rootulp/rsmt2d
1 participant
@rootulp