feat: introduce rsmt2d.ErrTooFewShards
#201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
- Coverage 80.80% 80.43% -0.37%
==========================================
Files 7 7
Lines 500 506 +6
==========================================
+ Hits 404 407 +3
- Misses 57 59 +2
- Partials 39 40 +1
|
|
On second thought, I think it may help readability to isolate the error handling logic inside |
rootulp
changed the title
rebuildSharesrsmt2d.ErrTooFewShards
rootulp
commented
Jun 29, 2023
| return nil, ErrTooFewShards | ||
| } | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
I'm finding it difficult to cover this line via unit tests by triggering an error in Reconstruct that isn't ErrTooFewShards or ErrShardNoData. Given this observation, this PR seems low priority.
|
Closing b/c #201 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199 but doesn't remove
rebuiltSharesCloses #200 via Option A