chore!: add error return params to tree interface

[rootulp]

Closes #156

[codecov]

Codecov Report

Merging #157 (1956b16) into master (1e85aab) will decrease coverage by 0.85%.
The diff coverage is 81.63%.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   82.28%   81.43%   -0.85%     
==========================================
  Files           7        7              
  Lines         508      528      +20     
==========================================
+ Hits          418      430      +12     
- Misses         54       58       +4     
- Partials       36       40       +4     

Impacted Files	Coverage Δ
extendeddatacrossword.go	74.03% <59.09%> (-2.50%)	⬇️
datasquare.go	93.71% <100.00%> (+0.28%)	⬆️
tree.go	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[evan-forbes]

nice! thanks for doing this, I think its a really good change!

only had a single comment, but otherwise LGTM 👍

[rootulp]

Before

goos: darwin
goarch: arm64
pkg: github.com/celestiaorg/rsmt2d
BenchmarkEDSRoots/32x32x256_ODS-10         	     880	   1277862 ns/op	 1791181 B/op	   34052 allocs/op
BenchmarkEDSRoots/64x64x256_ODS-10         	     393	   2902884 ns/op	 6203529 B/op	  133636 allocs/op
BenchmarkEDSRoots/128x128x256_ODS-10       	     100	  10280551 ns/op	26235483 B/op	  530439 allocs/op
BenchmarkEDSRoots/256x256x256_ODS-10       	      31	  37474563 ns/op	106997125 B/op	 2110473 allocs/op
BenchmarkEDSRoots/512x512x256_ODS-10       	       8	 142572162 ns/op	490815672 B/op	 8419332 allocs/op
PASS

After

goos: darwin
goarch: arm64
pkg: github.com/celestiaorg/rsmt2d
BenchmarkEDSRoots/32x32x256_ODS-10         	     939	   1268924 ns/op	 1791219 B/op	   34052 allocs/op
BenchmarkEDSRoots/64x64x256_ODS-10         	     400	   3206118 ns/op	 6203693 B/op	  133637 allocs/op
BenchmarkEDSRoots/128x128x256_ODS-10       	     121	   9694509 ns/op	26235166 B/op	  530437 allocs/op
BenchmarkEDSRoots/256x256x256_ODS-10       	      32	  35897461 ns/op	106996929 B/op	 2110477 allocs/op
BenchmarkEDSRoots/512x512x256_ODS-10       	       8	 137695750 ns/op	490829368 B/op	 8419440 allocs/op
PASS

[rootulp]

removed an unused function

[evan-forbes]

cc @Wondertan as this api change would have an effect on node

[rootulp]

It looks like @Wondertan doesn't have write permissions on this repo so his approval doesn't satisfy the 2 approvals requirement. I removed @MSevey 's review request b/c he's on parental leave so this needs @liamsi 's review.

[Wondertan]

And @liamsi is ooo as well, maybe @musalbas ?

[rootulp]

Maybe @cmwaters has write permission to this repo b/c he's a member of core/app