Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If the methods for the
Codec
interface are exported, then users can define their own interfaces outside of this package. I'm not sure if leaving the methods unexported was done on purpose, so if it was this PR can be closed.edit: for posterity this PR exported only a few methods, so it looks like it wasn't done on purpose, but I'm still unsure if there are any other specific reasons not to
Checklist