Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: export codec methods #195

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Jun 23, 2023

Overview

If the methods for the Codec interface are exported, then users can define their own interfaces outside of this package. I'm not sure if leaving the methods unexported was done on purpose, so if it was this PR can be closed.

edit: for posterity this PR exported only a few methods, so it looks like it wasn't done on purpose, but I'm still unsure if there are any other specific reasons not to

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #195 (3a98be8) into master (f0b3545) will not change coverage.
The diff coverage is 60.00%.

❗ Current head 3a98be8 differs from pull request most recent head 25e11e5. Consider uploading reports for the commit 25e11e5 to get more accurate results

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   81.15%   81.15%           
=======================================
  Files           7        7           
  Lines         520      520           
=======================================
  Hits          422      422           
  Misses         58       58           
  Partials       40       40           
Impacted Files Coverage Δ
codecs.go 50.00% <ø> (ø)
extendeddatasquare.go 73.62% <33.33%> (ø)
leopard.go 77.77% <100.00%> (ø)

Copy link

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@evan-forbes evan-forbes merged commit a5abc27 into master Jun 27, 2023
2 checks passed
@evan-forbes evan-forbes deleted the evan/export-codec-methods branch June 27, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants