test: do not perform input validation in setCell
#203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 80.80% 80.93% +0.13%
==========================================
Files 7 7
Lines 500 493 -7
==========================================
- Hits 404 399 -5
+ Misses 57 56 -1
+ Partials 39 38 -1
|
staheri14
reviewed
Jul 3, 2023
staheri14
approved these changes
Jul 3, 2023
rootulp
changed the title
setCell
rootulp
commented
Jul 3, 2023
Comment on lines
+98
to
100
| // Test_setCell verifies that setCell can overwrite cells without performing any | ||
| // input validation. | ||
| func Test_setCell(t *testing.T) { |
There was a problem hiding this comment.
on re-review it seems overkill to have a test for an un-exported function that only exists for the sake of testing so I can remove this unit test if reviewers request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #202 via Option A
Note: this isn't breaking b/c
setCellisn't exported.