Use Harfbuzz for shaping #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwiggins
force-pushed
the
feature/harfbuzz-shaping
branch
3 times, most recently
from
cd36783
to
9107da2
Compare
jwiggins
commented
Mar 22, 2021
jwiggins
force-pushed
the
feature/harfbuzz-shaping
branch
from
88a2b63
to
1df7677
Compare
|
Looks like the Harfbuzz library available via EDM (version 2.6.4) does not have GDI support. So no support on Windows for now. Guess I'll chase that down in a future PR... |
jwiggins
force-pushed
the
feature/harfbuzz-shaping
branch
from
1df7677
to
7cb9c29
Compare
|
Ready to move on with this one... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds proper text shaping using Harfbuzz. I've tested with several complex Indian scripts and it its output is comparable to other software as long as an appropriate font is used. It works quite well with the FreeType code path. Windows is yet untested. I still need to figure out how to handle the dependency there.