Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement proposal: add PEP 517/518 compliance #65

Open
staticdev opened this issue May 28, 2020 · 4 comments
Open

Enhancement proposal: add PEP 517/518 compliance #65

staticdev opened this issue May 28, 2020 · 4 comments

Comments

@staticdev
Copy link
Contributor

These PEPs recommend not using setup.py anymore:

  • Use poetry to create pyproject.toml
  • Delete setup.py
@staticdev staticdev changed the title Add PEP 517/518 compliance Enhancement proposal: add PEP 517/518 compliance May 28, 2020
@staticdev staticdev mentioned this issue May 28, 2020
Closed
@celiao
Copy link
Owner

celiao commented Jun 27, 2020

@staticdev Thanks for your suggestion. I poked around and many of the popular Python packages use setup.py still, so I'm inclined to stick with setup.py until more packages move over to poetry and pyproject.toml.

@staticdev
Copy link
Contributor Author

@celiao as you wish. We can maintain this PR on hold.

@celiao
Copy link
Owner

celiao commented Jun 29, 2020

@staticdev Great!

@celiao
Copy link
Owner

celiao commented Jan 22, 2022

If we ever decide to add PEP 517/518 compliance, check out PR #66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PEP 517/518 compliance staticdev/tmdbsimple
3 participants
@staticdev @celiao and others