False edition flag default #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
enhancement
clarifications
spec_main
Closed
hubblec4
reviewed
Sep 8, 2019
There was a problem hiding this comment.
In my eyes is that concept not really good/useful.
The first Edition with an EditionFlagDefault Flag(true) is the Default Edition even if the EditionFlagHidden Flag is set to true.
If the EditionFlagHidden is set to True the Matroska Player must not use chapter markers for this edition but the content of the edition must be played.
The EditionFlagDefault element should move up a level, but this is another story, I think.
robUx4
force-pushed
the
false-EditionFlagDefault
branch
from
257436f
to
30b8301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworded part of #336 and kept the concept of Default Edition