bug(experiment): Comp types not handled correctly #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbjornson
reviewed
May 2, 2022
gegnew
force-pushed
the
ge/146-comp-types
branch
5 times, most recently
from
076c7ff
to
09ef48d
Compare
|
Linting borked until #149 |
gegnew
force-pushed
the
ge/146-comp-types
branch
3 times, most recently
from
8364679
to
d5070f2
Compare
zbjornson
requested changes
May 11, 2022
|
Looks good but needs a rebase. |
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
+ Coverage 93.33% 93.63% +0.30%
==========================================
Files 67 67
Lines 2879 2905 +26
==========================================
+ Hits 2687 2720 +33
+ Misses 192 185 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Had to change |
zbjornson
approved these changes
Jun 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getter and setter methods for Experiment.active_compensation do not
handle special compensation types correctly. This fixes the bug and adds
tests.
See #146