You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
which do the same thing but is more performance efficient (check for moodle/site:config is done only once) and more straightforward to understand for reviewers :)
It also remove the global $context usage which is against Moodle coding guidelines. Global should by use only for moodle core global variables.
Optional (non blocking for approval) :
I think that instead of using moodle/course:update you should implements your own capability. This way you could use this plugin on role which do not have the permission to edit the course (such as tutor for example)
The text was updated successfully, but these errors were encountered:
Implementing function such as
is_allowed_to_display_students()
add complexity to your code.It should be replace by
which do the same thing but is more performance efficient (check for
moodle/site:config
is done only once) and more straightforward to understand for reviewers :)It also remove the
global $context
usage which is against Moodle coding guidelines. Global should by use only for moodle core global variables.Optional (non blocking for approval) :
I think that instead of using
moodle/course:update
you should implements your own capability. This way you could use this plugin on role which do not have the permission to edit the course (such as tutor for example)The text was updated successfully, but these errors were encountered: