solve the g_free incompatible-pointer-types #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnome-mpv
requested changes
Dec 4, 2018
src/gmpv_preferences_dialog.c
Outdated
| @@ -173,6 +173,11 @@ static GtkWidget *build_page( const PreferencesDialogItem *items, | |||
| gtk_widget_set_size_request(widget, 100, -1); | |||
| gtk_file_chooser_set_filename(chooser, filename); | |||
|
|
|||
| void free_data(gpointer data, GClosure *closure) | |||
There was a problem hiding this comment.
Don't use nested functions.
src/gmpv_preferences_dialog.c
Outdated
| @@ -173,6 +173,11 @@ static GtkWidget *build_page( const PreferencesDialogItem *items, | |||
| gtk_widget_set_size_request(widget, 100, -1); | |||
| gtk_file_chooser_set_filename(chooser, filename); | |||
|
|
|||
| void free_data(gpointer data, GClosure *closure) | |||
There was a problem hiding this comment.
It might be a good idea to rename this to something more specific (e.g. free_signal_data).
Easyghost195
force-pushed
the
deprecated_fonction
branch
from
a4e9a76
to
b696658
Compare
|
Sorry for this big mistake about the nested function. I pushed a correction of this with the static function and a better name of this function. |
|
Merged as 21ee21c. Thanks! In the future, don't forget to pull before committing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a g_free with incompatible pointer type in gmpv_preferences_dialog.c:
gmpv_preferences_dialog.c:184:7: warning: passing argument 5 of ‘g_signal_connect_data’ from incompatible pointer type [-Wincompatible-pointer-types] g_free,So there is a proposition to solve this make error.
Regards