add button repeat #400
add button repeat #400
Conversation
|
I think we should make the button indicate whether or not looping is currently enabled. It's going to be difficult to tell what the button is going to do otherwise. |
| @@ -419,6 +422,7 @@ static void gmpv_control_box_init(GmpvControlBox *box) | |||
| box->previous_button = gtk_button_new(); | |||
| box->fullscreen_button = gtk_button_new(); | |||
| box->volume_button = gtk_volume_button_new(); | |||
| box->repeat_button = gtk_button_new(); | |||
There was a problem hiding this comment.
| box->repeat_button = gtk_button_new(); | |
| box->repeat_button = gtk_toggle_button_new(); |
Use toggle button here so that the user can see whether or not looping is currently enabled.
There was a problem hiding this comment.
Shouldn't looping be tri-state, loop-off, loop-current, and loop-playlist?
There was a problem hiding this comment.
I think that it's enough to have loop-off and loop-playlist for this button. This seems to be what most media players do (and presumably the most common use case).
| @@ -446,6 +450,9 @@ static void gmpv_control_box_init(GmpvControlBox *box) | |||
| init_button( box->previous_button, | |||
| "media-skip-backward-symbolic", | |||
| _("Previous Chapter") ); | |||
| init_button( box->repeat_button, | |||
| "media-playlist-repeat", | |||
There was a problem hiding this comment.
| "media-playlist-repeat", | |
| "media-playlist-repeat-symbolic", |
Use tabs to indent. Also, explicitly use symbolic variant of the icon.
| @@ -511,6 +518,10 @@ static void gmpv_control_box_init(GmpvControlBox *box) | |||
| "clicked", | |||
| G_CALLBACK(simple_signal_handler), | |||
| box ); | |||
| g_signal_connect( box->repeat_button, | |||
There was a problem hiding this comment.
Instead of using click signal here, it would be better to create a new property and bind it with the loop-playlist property in GmpvModel. We can then bind the repeat button's active property to this property.
|
Edited and merged as 024c0fd. |
Following the request about "Suggestion to add a repeat button to the interface? #360"
I suggest you a clickable button for looping the current file:
Regards.