Skip to content
This repository has been archived by the owner on Dec 7, 2018. It is now read-only.

Support Ruby 2.3.0 #163

Merged
merged 2 commits into from Dec 30, 2015
Merged

Support Ruby 2.3.0 #163

merged 2 commits into from Dec 30, 2015

Conversation

tricknotes
Copy link
Contributor

In Ruby 2.3.0, UDPSocket#recvfrom's flags doesn't allow nil.
It should be Numeric value.

So I specified this default value to the same value as UDPSocket#recvfrom's.

@tricknotes
Copy link
Contributor Author

Currently many specs are failed.
However I wish #162 will fix them.

tricknotes added a commit to tricknotes/rubydns that referenced this pull request Dec 30, 2015
This is a workaround for behavior change against Celluloid::IO with Ruby 2.3.
see also: celluloid/celluloid-io#163
@tarcieri
Copy link
Member

Looks benign enough despite the existing test failures

tarcieri added a commit that referenced this pull request Dec 30, 2015
@tarcieri tarcieri merged commit 1d563d3 into celluloid:master Dec 30, 2015
@tricknotes tricknotes deleted the ruby-2.3 branch December 31, 2015 00:15
@tricknotes
Copy link
Contributor Author

Oops, I missed some failing specs such as the following:

  1) Celluloid::IO::DNSResolver#resolve resolves hostnames
     Failure/Error: expect(resolver.resolve("localhost")).to eq(Resolv::IPv4.create("127.0.0.1")).or eq(Resolv::IPv6.create("::1"))

     RuntimeError:
       can't modify frozen String
     # /home/travis/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/resolv.rb:2463:in `block in create'
     # /home/travis/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/resolv.rb:2463:in `scan'
     # /home/travis/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/resolv.rb:2463:in `create'
     # ./spec/celluloid/io/dns_resolver_spec.rb:15:in `block (3 levels) in <top (required)>'

https://travis-ci.org/celluloid/celluloid-io/jobs/99525963

However this is a Ruby's bug: https://bugs.ruby-lang.org/issues/11910
And it is fixed on trunk.

Should we remove 2.3.0 from .travis.yml until Ruby 2.3.1 released?

@tricknotes
Copy link
Contributor Author

Thanks for your merge ✨
I'm happy if you release a new version with this change ❤️

@tarcieri
Copy link
Member

tarcieri commented Jan 4, 2016

@digitalextremist were you planning a release for this soon? Otherwise I can. It seems like all of the projects could use another release.

@ioquatix
Copy link
Contributor

ioquatix commented Jan 5, 2016

Yes I'd like to see another release with the changes including the socket base class. Can we please get the rspec/testing issues fixed and then I will merge that code then we do a release? Perhaps 0.17.3? I'd also like to have a hangout with everyone at some point to discuss the path to 1.0.0

@dblock
Copy link

dblock commented Jan 8, 2016

+1 on a release, want for https://github.com/dblock/slack-ruby-client

@tarcieri
Copy link
Member

tarcieri commented Jan 8, 2016

Okay, I'll do a release this weekend

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants