-
Notifications
You must be signed in to change notification settings - Fork 93
Conversation
Currently many specs are failed. |
This is a workaround for behavior change against Celluloid::IO with Ruby 2.3. see also: celluloid/celluloid-io#163
Looks benign enough despite the existing test failures |
Oops, I missed some failing specs such as the following:
https://travis-ci.org/celluloid/celluloid-io/jobs/99525963 However this is a Ruby's bug: https://bugs.ruby-lang.org/issues/11910 Should we remove |
Thanks for your merge ✨ |
@digitalextremist were you planning a release for this soon? Otherwise I can. It seems like all of the projects could use another release. |
Yes I'd like to see another release with the changes including the socket base class. Can we please get the rspec/testing issues fixed and then I will merge that code then we do a release? Perhaps 0.17.3? I'd also like to have a hangout with everyone at some point to discuss the path to 1.0.0 |
+1 on a release, want for https://github.com/dblock/slack-ruby-client |
Okay, I'll do a release this weekend |
In Ruby 2.3.0,
UDPSocket#recvfrom
'sflags
doesn't allownil
.It should be Numeric value.
So I specified this default value to the same value as
UDPSocket#recvfrom
's.