Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The lack of the at_exit handler causes hard deadlocks #200

Merged
merged 1 commit into from Apr 19, 2013

Conversation

halorgium
Copy link
Contributor

If you run this: https://gist.github.com/halorgium/14465667d26e4b053180
You will get a deadlock.

This is definitely an issue with TaskFibers only as TaskThread behaves correctly.

We either need to add the at_exit handler back or get to the root cause.

@halorgium
Copy link
Contributor Author

We should add a new method for installing the at_exit handler.
That way people can boot Celluloid without default actors but with the safety of clean shutdown.

@halorgium
Copy link
Contributor Author

This is only a problem on MRI 1.9.3, 2.0.0-p0 does not have this issue.

@halorgium
Copy link
Contributor Author

I started a discussion somewhat related to this at https://groups.google.com/d/msg/celluloid-ruby/Rd2AurcPNpo/xejk2OT3zwEJ

Mainly questioning whether we should support "no default actors".

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2f9ca29 on halorgium:at-exit-by-default into d84b67a on celluloid:master.

halorgium added a commit that referenced this pull request Apr 19, 2013
The lack of the at_exit handler causes hard deadlocks
@halorgium halorgium merged commit a3d5787 into celluloid:master Apr 19, 2013
@halorgium halorgium deleted the at-exit-by-default branch April 19, 2013 05:47
@tarcieri
Copy link
Member

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants