Skip to content
This repository has been archived by the owner on Dec 7, 2018. It is now read-only.

Revert PR#131 #137

Closed
wants to merge 2 commits into from
Closed

Revert PR#131 #137

wants to merge 2 commits into from

Conversation

unakatsuo
Copy link
Contributor

recent changes for http gem breaks reel. it is good to keep the dependency on 0.5.x series.

websocket_parser gem has left http gem since v0.16.0 release. I believe that #131 was just needed to bump websocket_parser gem version.

Reel's master branch build started to fail after the PR httprb/http#80 because of the removal of lib/http/header.rb.

Build log for master HEAD (5ee0ae4)
https://travis-ci.org/unakatsuo/reel/jobs/19233177

$ bundle install
$ bundle exec rake
/home/travis/.rvm/rubies/ruby-2.0.0-p353/bin/ruby -S rspec ./spec/reel/connection_spec.rb ./spec/reel/http_server_spec.rb ./spec/reel/https_server_spec.rb ./spec/reel/response/writer_spec.rb ./spec/reel/response_spec.rb ./spec/reel/websocket_spec.rb
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's default settings.
/home/travis/build/unakatsuo/reel/lib/reel/response.rb:5:in `<class:Response>': uninitialized constant HTTP::Header (NameError)
    from /home/travis/build/unakatsuo/reel/lib/reel/response.rb:4:in `<module:Reel>'
    from /home/travis/build/unakatsuo/reel/lib/reel/response.rb:3:in `<top (required)>'

@tarcieri
Copy link
Member

Can you better describe the breakage you're experiencing? Reel CIs against the http gem master, so if there's a problem it indicates a lack of coverage in the test suite.

@unakatsuo
Copy link
Contributor Author

I have added the details.

@Asmod4n
Copy link
Contributor

Asmod4n commented Feb 20, 2014

Currently, when you have

gem 'http', github: 'tarcieri/http'
gem 'reel', github: 'celluloid/reel'

in your Gemfile, reel doesn't start.

uninitialized constant HTTP::Header
/home/xxx/.gem/ruby/2.1.0/bundler/gems/reel-5ee0ae49ac76/lib/reel/response.rb:5:in `<class:Response>'

HTTP::Headers is now a Class, so you can't include it anymore —_—

@tarcieri
Copy link
Member

We should update Reel to be compatible with the new HTTP Gem API rather than trying to roll back to the antiquated version.

@tarcieri tarcieri closed this Feb 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants