This repository has been archived by the owner on Dec 7, 2018. It is now read-only.
Remove optimize function #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it isn't used and it doesn't work
|
Indeed! Disabling Nagle on a server's listen socket probably isn't going to do a whole hell of a lot 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is only used by the servers. Except... it is wrapped with this code:
Obviously, TCPSocket refers to C::IO::TCPSocket and not to ::TCPSocket. In the both servers' contexts, things to optimize are: Celluloid::IO::TCPServer. C::IO::TCPServer is not a C::IO::TCPSocket, nor it subclasses one, so the code never evaluates.
After some talk with @tarcieri on IRC, he told me, that the function doesn't make sense on a listener (ie. server) socket. And it isn't used in any other context.
Thus, the pull request just removes unused code.