This repository has been archived by the owner on Dec 7, 2018. It is now read-only.
Extend streaming support and pass streaming bodies through Rack #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Give me a bit more time to review this in detail, but I like where you're going |
| @@ -138,24 +138,23 @@ def respond(response, headers_or_body = {}, body = nil) | |||
| # Write body chunks directly to the connection | |||
| def write(chunk) | |||
| raise StateError, "not in chunked body mode" unless @response_state == :chunked_body | |||
| chunk_header = chunk.bytesize.to_s(16) + Response::CRLF | |||
| @socket << chunk_header | |||
There was a problem hiding this comment.
This was faster because no new string instances
|
@tarcieri, had you a chance to take a look over this? any plans regard new gem release? |
|
Sorry, haven't had time to review this yet. And yeah, I can spin a new gem release. |
tarcieri
added a commit
that referenced
this pull request
Dec 3, 2012
Extend streaming support and pass streaming bodies through Rack
kenichi
pushed a commit
to kenichi/reel
that referenced
this pull request
Aug 4, 2016
Updated/improved deleting_timer,configuration,crypto and specs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added seamless support for Server-Sent Events, Chunked bodies as well as generic streamed bodies.
See
examples/server-sent-events.rb,examples/chunked.rbandexamples/stream.rbWill do my best to write full specs for this when/if i get some time.
Also fixed streaming support for Enumerable - there were missing
CRLFafter each chunk.