Skip to content
This repository has been archived by the owner on Dec 7, 2018. It is now read-only.

Added tests for Reel::Request #227

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added tests for Reel::Request #227

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f36f4cf
Added tests for Reel::Request
prathmeshranaut Jun 18, 2016
09afb91
Added a test to make sure that the connection detaches successfully
prathmeshranaut Jun 18, 2016
452c368
Merge branch 'master' of https://github.com/celluloid/reel
prathmeshranaut Jun 18, 2016
1dfca6b
Refactored a test
prathmeshranaut Jun 19, 2016
ff9047a
Spec to write array messages
prathmeshranaut Aug 3, 2016
bd7f592
Added test for array and non-string websocket messages
prathmeshranaut Aug 4, 2016
9a8ed5f
Extracted the example request string
prathmeshranaut Aug 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions spec/reel/connection_spec.rb
View file
Open in desktop
Expand Up @@ -338,6 +338,17 @@ def test_chunked_response(request, client)
end
end

it "detaches a connection properly" do
with_socket_pair do |client, peer|
connection = Reel::Connection.new(peer)
client << ExampleRequest.new.to_s
c = connection.detach

expect(c).to be_a Reel::Connection
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@digitalextremist Do you we can combine line 345 with this line?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @aayushranaut, you can move connection.detach into the expect() call.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@digitalextremist Moved connection.detach into expect() call.

expect(connection.attached?).to eq(false)
end
end

it "returns friendlier inspect output" do
with_socket_pair do |client, peer|
connection = Reel::Connection.new(peer)
Expand Down