Skip to content
This repository has been archived by the owner on Dec 7, 2018. It is now read-only.

Patch to solve #87 #88

Merged
merged 1 commit into from
Sep 12, 2013
Merged

Patch to solve #87 #88

merged 1 commit into from
Sep 12, 2013

Conversation

digitalextremist
Copy link
Member

Solve #87

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.32%) when pulling 9f349f4 on digitalextremist:io-work-arou into 470e33d on celluloid:master.

@digitalextremist
Copy link
Member Author

Actually, there is a better way to do this? ::IO.try_convert()

Please verify this is better and I will update my patch.

/cc: @tarcieri, @halorgium

@tarcieri
Copy link
Member

@digitalextremist ::IO.try_convert is unnecessary because @socket will always be a Celluloid::IO socket that responds to #to_io

@digitalextremist
Copy link
Member Author

Roger

tarcieri added a commit that referenced this pull request Sep 12, 2013
@tarcieri
Merge pull request #88 from digitalextremist/io-work-arou
6b9ecf0 
Patch to solve #87
@tarcieri tarcieri merged commit 6b9ecf0 into celluloid:master Sep 12, 2013
@tarcieri
Copy link
Member

Eventually I'll add Celluloid::IO.copy_stream to make this a little easier

@digitalextremist digitalextremist deleted the io-work-arou branch September 12, 2013 03:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@digitalextremist @coveralls @tarcieri