Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/comments column too short #297

Merged
merged 4 commits into from Jun 30, 2021
Merged

Bugfix/comments column too short #297

merged 4 commits into from Jun 30, 2021

Conversation

rkachowski
Copy link

closes #293

Changelog

Enhancements

  • Added test for token transfer insertion

Bug Fixes

  • changes comment field type on token_transfers table from varchar(1024) to text (celo protocol specifies no upper limit on the size of the comment field)

@rkachowski rkachowski requested a review from a team June 29, 2021 12:42
@rkachowski rkachowski self-assigned this Jun 29, 2021
@rkachowski rkachowski marked this pull request as ready for review June 29, 2021 12:42
carterqw2
carterqw2 approved these changes Jun 29, 2021
View reviewed changes
Copy link

@carterqw2 carterqw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are issues with formatting but other than that looks good!

@rkachowski rkachowski merged commit bae2f47 into master Jun 30, 2021
@rkachowski rkachowski deleted the bugfix/comments-column-too-short branch June 30, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterqw2 carterqw2 carterqw2 approved these changes

Assignees

@rkachowski rkachowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blockscout can't insert token transfers with long comments
2 participants
@rkachowski @carterqw2