Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies consuming bls-zexe dependency #1022

Merged
merged 13 commits into from May 16, 2020
Merged

Conversation

kobigurk
Copy link
Contributor

@kobigurk kobigurk commented May 3, 2020

Description

Rust is not needed anymore to build bls-zexe. https://github.com/celo-org/celo-bls-go is the Go module that is now used. It's versioned and provides pre-built binaries for all the supported platforms.

Other changes

Updates to latest bls-zexe that uses a compatibility mode to use the current consensus-compatible hash-to-group.

Tested

Tested all the different supported platforms:

  • MacOS
  • Linux
  • ARM
  • Android
  • iOS

End-to-end tests check syncing and verified syncing against RC1.

Copy link
Contributor

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Can we ensure that a node can sync with this change before merging it?

@kobigurk
Copy link
Contributor Author

kobigurk commented May 4, 2020

Fantastic. Can we ensure that a node can sync with this change before merging it?

End-to-end tests check syncing and verified against RC1 now!

In any case, I'll merge this after properly releasing celo-bls-go, when we merge the bls-zexe PR.

Copy link
Contributor

@mcortesi mcortesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best PR of 2020 :D

@kobigurk kobigurk changed the title Simplifies consuming bls-zexe dependency [DON'T MERGE YET] Simplifies consuming bls-zexe dependency May 6, 2020
@asaj asaj assigned kobigurk and unassigned timmoreton, mcortesi and asaj May 12, 2020
@kobigurk kobigurk changed the title [DON'T MERGE YET] Simplifies consuming bls-zexe dependency Simplifies consuming bls-zexe dependency May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants