CIP-28: Split etherbase into validator & txFeeRecipient addresses #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess for state transitions
…er.coinbase instead
mcortesi
reviewed
Nov 6, 2020
mcortesi
reviewed
Nov 6, 2020
9 tasks
mcortesi
changed the title
mcortesi
changed the title
# Conflicts: # contract_comm/random/random.go # eth/backend.go # eth/gen_config.go # miner/miner.go # miner/worker.go # miner/worker_test.go
mcortesi
reviewed
Jan 14, 2021
| @@ -456,7 +464,11 @@ func (w *worker) mainLoop() { | |||
| continue | |||
| } | |||
| w.mu.RLock() | |||
| coinbase := w.coinbase | |||
| txFeeRecipient := w.txFeeRecipient | |||
| if !w.chainConfig.IsDonut(w.current.header.Number) && w.txFeeRecipient != w.validator { | |||
There was a problem hiding this comment.
do we know if current.header != nil?
There was a problem hiding this comment.
The only function that sets the current is makeCurrent, which is called only by the Prepare function after initialising the header.
I can't use the header.Coinbase in that line, because it's the case where the consensus is not running, and leaves the header.Coinbase with nil
# Conflicts: # eth/backend.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation for CIP-28.
Both parameters are set via command line
New flags:
miner.validatoris the validator addresstxFeeRecipientthe address where all the fees payments will be transferredIf one of these flags is present, the other will be required, even if it is the same address, to force a conscious decision about it
To maintain backwards compatibility, the
etherbaseflag if is already set, and non of the other two flags were set, it will fill that address as theminer.validatorand thetxFeeRecipient. The flag will eventually be deprecated.We changed the default behaviour of the etherbase flag. Now it won't assume the first account of the keyStore as default. So beware. Either the
etherbaseflag or the pairminer.validatorandtxFeeRecipientMUST be set.Other changes
Split etherbase in ethstats.
Related issues
Backwards compatibility
Hardfork Change. Modifies block validation logic. Part of
DonutHardfork