Fix goroutine leak in celostats login. #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The channel needs to be buffered, so that if a timeout occurs the goroutine would still be able to terminate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The channel needs to be buffered, so that if a timeout occurs the goroutine would still be able to terminate.
Description
Fixes a goroutine leak spotted by @zviadm. Note that this leak is new, and was not present on v1.1.0.
Tested
Not tested directly, but build and unit tests pass.
Related issues
Backwards compatibility
No effect on protocols, so no backwards compatibility concerns.