Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile interface ComputeECDHSharedSecret #1219

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Conversation

hbandura
Copy link
Contributor

@hbandura hbandura commented Nov 9, 2020

No description provided.

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The wsddn/go-ecdh library was already added to the project and seems fine: we don't use any curves from it, just it doing ECDH on a provided elliptic.

@AlexBHarley
Copy link
Contributor

If there are concerns about wsddn/go-ecdh, there's also no problem calling directly into the go crypto module. The operation is simple enough not to warrant going via an extra library https://github.com/wsddn/go-ecdh/blob/master/elliptic.go#L81. That was how I originally imagined implementing this

@hbandura hbandura merged commit 416e518 into master Nov 11, 2020
@hbandura hbandura deleted the hbandura/mobileECDH branch November 11, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement CIP8 primitives for mobile access
3 participants