Split out startNewSequence from core.startNewRound #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trianglesphere
requested review from
mcortesi and
gastonponti
and removed request for
a team
oneeman
reviewed
Mar 31, 2021
oneeman
reviewed
Mar 31, 2021
oneeman
reviewed
Mar 31, 2021
Co-authored-by: Or Neeman <or@clabs.co>
…o-blockchain into trianglesphere/new_sequence
oneeman
reviewed
Apr 1, 2021
trianglesphere
pushed a commit
that referenced
this pull request
Apr 8, 2021
* Split new round and new sequence into two functions * More cleanup * Update consensus/istanbul/core/core.go Co-authored-by: Or Neeman <or@clabs.co> * Use correct author in startNewRound * Clean up next proposer logic and logs Co-authored-by: Or Neeman <or@clabs.co>
trianglesphere
pushed a commit
that referenced
this pull request
Apr 9, 2021
* Split new round and new sequence into two functions * More cleanup * Update consensus/istanbul/core/core.go * Use correct author in startNewRound * Clean up next proposer logic and logs Co-authored-by: Or Neeman <or@clabs.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This creates a function called
core.startNewSequencethat is used in place ofcore.startNewRound(common.Big0). This helps clean up the code and simplifies the logic of starting new rounds and sequences.Tested
Unit tests