Only active validator signs stats #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonponti
requested review from
kevjue and
trianglesphere
and removed request for
a team
oneeman
reviewed
Apr 13, 2021
Co-authored-by: Or Neeman <or@clabs.co>
oneeman
approved these changes
Apr 13, 2021
oneeman
pushed a commit
that referenced
this pull request
Apr 14, 2021
Description A proxy with two validators (one active) that send a stat to be signed by the validator, was receiving 2 signed messages for the same (one per validator) Only the active validator will sign those stats. Other changes The validators MUST have the celostats flag too (as we have it in the docs) Tested Manually Backwards compatibility Breaking change in that proxied validators need to specify the celostats flag in order to report to celostats. However, this new behavior agrees with our documentation, so this is really more of a bugfix.
oneeman
pushed a commit
that referenced
this pull request
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A proxy with two validators (one active) that send a stat to be signed by the validator, was receiving 2 signed messages for the same (one per validator)
Only the active validator will sign those stats.
Other changes
The validators MUST have the celostats flag too (as we have it in the docs)
Tested
Manually
Backwards compatibility
Breaking change in that proxied validators need to specify the celostats flag in order to report to celostats. However, this new behavior agrees with our documentation, so this is really more of a bugfix.